gcosma / ClanBasedCulturalAlgorithFS

Clan-based Cultural Algorithm for Feature Selection
3 stars 2 forks source link

KNN doesn't return conf #1

Open YasminFathy opened 4 years ago

YasminFathy commented 4 years ago

Hi,

Thanks for sharing your code. I have noticed that Knn.m returns 7 values [ accuracy, aucValues, msError, OPTROCPT,precision, f1,recall]; however, in createIndv.m, you expected 8 returned values from KNN: [indv.accuracy,indv.AUCval,indv.mse, ... indv.OPTROCPT, indv.precision,indv.F1, indv.recall,indv.conf] = knn(X1, T );

The script won't start running until you remove indv.conf from createIndv.m

Thanks, Yasmin

gcosma commented 4 years ago

Thanks Yasmin. I will check when I get into the office Can you share with me your code? Georgina

Get Outlook for Androidhttps://aka.ms/ghei36


From: Yasmin Fathy notifications@github.com Sent: Friday, 21 February 2020, 16:53 To: gcosma/ClanBasedCulturalAlgorithFS Cc: Subscribed Subject: [gcosma/ClanBasedCulturalAlgorithFS] KNN doesn't return conf (#1)

Knn.m returns 7 values [ accuracy, aucValues, msError, OPTROCPT,precision, f1,recall]; however, in createIndv.m, you expected 8 returned values from KNN: [indv.accuracy,indv.AUCval,indv.mse, ... indv.OPTROCPT, indv.precision,indv.F1, indv.recall,indv.conf] = knn(X1, T );

The script won't start running until you remove indv.conf from createIndv.m

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/gcosma/ClanBasedCulturalAlgorithFS/issues/1?email_source=notifications&email_token=AF6SEMQMVQCXAB5GQSVXPYLREABI5A5CNFSM4KZGULB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IPLJ6TA, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF6SEMQTSOJJPEOPYHFSZA3REABI5ANCNFSM4KZGULBQ.

YasminFathy commented 4 years ago

Thanks, Georgina! Yes, sure. I changed only line 32-33: https://github.com/gcosma/ClanBasedCulturalAlgorithFS/blob/7d4c72a11128856f33c0008507c35b9124370d51/createIndv.m#L32 with: [indv.accuracy,indv.AUCval,indv.mse, ... indv.OPTROCPT, indv.precision,indv.F1, indv.recall] = knn(X1, T );

If this is not clear, I can upload your file on my Github and send you the link?

Many Thanks, Yasmin