gcp-pdp / geo-openstreetmap

32 stars 6 forks source link

Missing geometry even when lat/lon present #26

Open nanodan opened 4 years ago

nanodan commented 4 years ago

the planet_nodes table seems to be missing some geometries, even when the lat/lon exists.

Example:

select *
  from `bigquery-public-data.geo_openstreetmap.planet_nodes` 
where id = 705843564

This occurs quite a lot:

select count(1)
 from `bigquery-public-data.geo_openstreetmap.planet_nodes` 
where geometry is null
  and latitude is not null 
  and longitude is not null

The above query returns 6121356366 rows (97% of the table)

pseveryn commented 4 years ago

@Pseverin thanks! I see that there are missing data at the bigquery-public-data.geo_openstreetmap.planet_points (GDAL branch of the pipeline). Take it into the work

pseveryn commented 4 years ago

@nanodan, it turned out, that GDAL generates geometry only for Nodes that contain tags (in other words, Nodes that represent some independent real objects). If some node is just a part of a larger object (e.g. way, multipolygon, etc.), GDAL would skip geometry for this node.

Could you please provide the use case where you need these geometries?

nanodan commented 3 years ago

@Pseverin I use some untagged nodes (when they are multiply connected) to identify the locations of junctions between ways.

allenday commented 3 years ago

so if I understand correctly, we should file an issue with GDAL upstream repo to export untagged points.