gcrahay / otx_misp

Imports Alienvault OTX pulses to a MISP instance
Other
52 stars 42 forks source link

Distribution level for MISP attributes should be set to inherit from event #22

Closed obert01 closed 6 years ago

obert01 commented 6 years ago

The distribution level for MISP attributes should be set to inherit from the event's distribution level rather than being forced to the distribution level configured for events.

This should better fit the case where we have to change the event's distribution level later in MISP. Anyway, it should better correspond to the MISP default philosophy.

gcrahay commented 6 years ago

There's a MISP setting (MISP.default_attribute_distribution, default "Inherit"). Why should otx-misp override this setting?

obert01 commented 6 years ago

You are right. I am aware of this MISP setting, but I encountered a problem where the distribution level of each MISP attribute was systematically set to "organization".

I have the impression this issue doesn't occur anymore. Anyway, this would be an issue with MISP.

Sorry to have bothered you with that.