search

gcrahay / otx_misp

Imports Alienvault OTX pulses to a MISP instance
Other
52 stars 42 forks source link

Fix Publish Ability #36

Open TheDr1ver opened 5 years ago

TheDr1ver commented 5 years ago

If creating a new event without any attributes attached to it, the API blocks the creation of the event and it will never make its way into MISP. Forcing published=False at this stage fixes the issue. Once the event has been populated the final publishing will be handled by ln 435.

chrisinmtown commented 4 years ago

Does this PR include everything in PR #33?

TheDr1ver commented 4 years ago

All #33 does is set the default publish value to False, but the user can easily change that when they call create_event(). #36 makes sure publish is explicitly set to False throughout the creation of the event until the event has been populated with attributes, then takes the publish value into account at the very end.

That all being said, I think if you use the code from PR #35 this largely becomes a moot point.