search

gctools-outilsgc / concierge

OAuth2 and OpenID microservice used for handling user registration, login and SAML2 SSO
https://account-compte.gccollab.ca
European Union Public License 1.1
11 stars 4 forks source link

GCaccount registration - A11y issues with password requirements #222

Closed piet0024 closed 1 year ago

piet0024 commented 2 years ago

The password requirements on GCAccount registration do not appear to get picked up by assistive technology. There are also issues with the hover / onclick icon in the password label. Rethink an accessible way to display the password requirements.

Image

LecCory commented 2 years ago

Removed the hover icon, and placed the password requirements into the form beneath the password fields. Also added visual queues to indicate when a requirement has been met

Image

LecCory commented 1 year ago

@piet0024 As this is a small change to the UI and also the user experience should we have the UI/UX team review before merging the PR? I know I've made visual queues but have I created an additional accessibility issue by using Red/Green color coding?

piet0024 commented 1 year ago

Yes, I agree I will try and coordinate getting someone from the UX team to review this before we merge. I will also find some time to do a code review.

piet0024 commented 1 year ago

https://github.com/gctools-outilsgc/concierge/pull/243