logging in to message.gccollab.ca sends user to account page instead of Rocket chat

gctools-outilsgc / concierge

OAuth2 and OpenID microservice used for handling user registration, login and SAML2 SSO

https://account-compte.gccollab.ca

European Union Public License 1.1

11 stars 4 forks source link

logging in to message.gccollab.ca sends user to account page instead of Rocket chat #42

Open PhilAndrecheck opened 6 years ago

PhilAndrecheck commented 6 years ago

When a user first logs in to message.gccollab.ca with the gccollab account, the user lands on the account page rather than being sent to rocket. If the user has previously logged in from a certain machine, even if he or she has logged out, a successful login WILL send the user to Rocket chat.

markwooff commented 6 years ago

Just tested this by creating a new GCcollab Account user, logging out of said user, and attempting a new login to https://message.gccollab.ca. Clicked the "Login with GCcollab Account" button, logged into the new user account, was asked to authorize, and was successfully brought back to RocketChat.

This issue may have been fixed as part of RocketChat's latest v0.63.1 release (https://github.com/RocketChat/Rocket.Chat/releases) unless there was a step I'm missing in trying to reproduce this issue. @LemieuxGen perhaps someone can verify this?

LemieuxGen commented 6 years ago

@klecuyer as you did some testing around this, can you provide details to Mark?

klecuyer commented 6 years ago

@markwooff it could have been fixed already, but when I was testing, as @smellems mentioned I think, if you change any settings, unsuccessfully guess your password, or toggle between languages when logging in, it seems to direct you to the account page. It wasn't every time but it seemed like if I unsuccessfully logged in or changed any settings (aka not a straight-forward login) it would bring me to the account page instead.

markwooff commented 6 years ago

It sounds like the user flow technically works then, but there are edge cases where the flow gets disrupted by various clicks/changes along the way. Okay well the good news is that if we decide to add GCcollab Message as part of our services this sprint, the icon will appear as part of the Tools area in the Account service as a fail-safe way to bring users back: