gctools-outilsgc / gccollab

Other
23 stars 7 forks source link

Colleagues don't all display on profile #314

Open klecuyer opened 6 years ago

klecuyer commented 6 years ago

As a user, I want to see how many colleagues I have and be able to interact with them.

For some reason, when I look at my profile, I see only 10 colleagues: https://gccollab.ca/profile/Ashleyevans image

But when I click to see a full list, I actually have over 100 colleagues: https://gccollab.ca/friends/Ashleyevans image

markwooff commented 6 years ago

By default, the list of "My Colleagues" would only show 10 users. I've increased this to 14 to fill out the column and the # of colleagues should now be correct.

klecuyer commented 6 years ago

@markwooff just had a user report this in GCconnex. Can we pull this fix over easily?

If not I'll create a new ticket. image

markwooff commented 6 years ago

The fix should be applied to GCconnex as well whenever the next code push is done 👌

klecuyer commented 6 years ago

It looks like the colleagues display properly on a user's profile now. @markwooff can you speak to the way the user's colleagues display on their colleagues page? Specifically if they have over 700 colleagues. You can see it in action here: https://gcconnex.gc.ca/friends/Ainslie.Nolan

It looks like it displays the first 700 in 10 per page (70 pages) but there's another separate page navigation for the remainder image image

*edit I know this example is in GCconnex but I understand the fix was pushed in both connex and collab

markwooff commented 6 years ago

Yeah this is separate from the previous issue, but I can say that the pagination for that section is a little wonky because the first row of pagination is because the users are displays in "data tables". When you click on those numbers, the list above reloads instantly. Clicking on the second row brings in a whole new batch of users that get loaded into the data table for the same functionality.

I imagine this was done because it would be very slow to load in 700+ users into a data table. I would advise creating a separate issue for this and have someone with more knowledge on the subject take a look 👍