Duplicate notifications and GCcollab Digest emails being sent

[klecuyer]

Duplicate emails/notifications have been an issue. https://github.com/gctools-outilsgc/gcconnex/issues/1414 Notifications even after unsubscribing have been an issue. https://github.com/gctools-outilsgc/gccollab/issues/361

As a short-term solution, the digest has been offered, and even suggested as a possible automatic setting for new accounts, until we get a hang on emails/notifications.

Now, a user is reporting getting duplicate digest emails (3). https://gccollab.gctools-outilsgc.ca/helpdesk/tickets/4825 User email: JENNIFER.LAWRENCEBYRNE@forces.gc.ca

[Phanoix]

This is most likely tied to multiple instances of collab running in the back end, I was hoping this was written in a way that this wouldn't happen but I guess we're not that lucky.

[nschonni]

Seeing the duplicates as well, not sure if it's related but I didn't see any digests the previous week

[klecuyer]

Same user Jennifer.LawrenceByrne@forces.gc.ca reports getting 3 GCcollab digest emails this morning again. 1 yesterday, and none the day before that (Aug 25)

[klecuyer]

User Michelle.Garraway@durham.ca reporting multiple duplicates for the same posts

[Phanoix]

Did that post itself get duplicated or is this multiple notifications for the exact same copy / non-duplicated post?

[klecuyer]

Most of the time the reports are made by other users and not the person directly uploading/posting, but as far as I can see this is from one event. Based on the number of cases reported and the times shown (at least in the digest emails) these are duplicates of the same thing.

[klecuyer]

Issues seem to be largely tied to this group: https://gccollab.ca/groups/profile/85014/enthe-policy-communityfrla-communautu00e9-des-politiques

Both for duplicate notifications AND for users still receiving notifications after unsubscribing or even leaving the group #361

[klecuyer]

https://gccollab.gctools-outilsgc.ca/helpdesk/tickets/4910 This user reports getting email notifications even after unsubscribing. I am able to remove her subscription in the admin panel. I'm not 100% sure if this removes site notifications or just email. https://gccollab.ca/profile/vanessalschwirtz

[nschonni]

For the daily digest, I'm seeing one with content and 2 "no activity" ones since one seems to be marking the work as done

[Phanoix]

Thanks @nschonni that does make sense. I guess the digest will need to be patched to handle its work in a more robust message queue fashion. Currently It clearly assumes only one running process.

[klecuyer]

@Phanoix just checking. Does this also fix either of these: https://github.com/gctools-outilsgc/gcconnex/issues/1414 https://github.com/gctools-outilsgc/gcconnex/issues/1070

[Phanoix]

This is specifically for the digest sending process, for content / post duplication I can do something more like gctools-outilsgc/gcconnex#1897, which seems to be working.

[klecuyer]

@Phanoix if a user reported still getting duplicates over the weekend, would this be resolved as of today? Or does it mean I should reopen the issue.

[nschonni]

I think I saw them Friday/Saturday, but not this morning

[Phanoix]

The patch went up in time for the most recent set of digests only, so the expected outcome is as @nschonni said (that's also what I got with my digests).