search

gcucurull / visual-compatibility

Context-Aware Visual Compatibility Prediction (https://arxiv.org/abs/1902.03646)
115 stars 37 forks source link

Added logging for create_dataset.py #12

Closed gayalkuruppu closed 4 years ago

gayalkuruppu commented 4 years ago

removed print statement and added logging instead to track the dataset process when running using nohup command in the cloud(to run this command in the background in cloud virtual machine).

gcucurull commented 4 years ago

Hello,

Thank you for your interest and help into improving the code.

Do you think it would be worth changing all the print statements in the code by logging? It would make the code more consistent across files.

I'm happy to merge this but I think it could be better to do it in every file, what do you think?

gayalkuruppu commented 4 years ago

Hello,

Yes I would think the same. I have changed them all in my repo, I have put a new PR.