search

gcv / julia-snail

An Emacs development environment for Julia
GNU General Public License v3.0
231 stars 21 forks source link

Eat: don't allow reusing an existing terminal buffer #134

Closed berquist closed 7 months ago

berquist commented 7 months ago

Closes #133

Passing the prefix argument to eat forces creating a new session.

There was also a problem with reading the buffer-local value of julia-snail-repl-buffer that the vterm path avoids. I think it's because in that branch the current buffer is still the source when the vterm buffer is created. This isn't a problem with the port number because the launch command is formed similarly. It is possible to create an Eat process inside one's own buffer like you do for vterm (see the eat-exec call in eat--1) but that would involve copying probably the entire block at https://codeberg.org/akib/emacs-eat/src/commit/5aaad960c8f0caa2bc4c8b2f9da4dc0c809550fe/eat.el#L7057.

Let me know if you'd prefer a different solution.

gcv commented 7 months ago

Looks good to me! Thank you very much.