search

gcv / julia-snail

An Emacs development environment for Julia
GNU General Public License v3.0
235 stars 23 forks source link

remove hardcoded check on major mode #139

Closed jesseylin closed 8 months ago

jesseylin commented 8 months ago

I think this is unnecessary for a minor-mode that will realistically never be invoked outside of Julia files (following convention of cider-mode for Clojure). Additionally, the hardcoded check means julia-snail does not initialize for julia-ts-mode, or in theory any other major mode with another name that the user may want to activate for julia files.

gcv commented 8 months ago

I'm okay with that change. I don't think Snail has any hard dependencies on julia-mode behaviors. Have you actually tried Snail with julia-ts-mode, and if so, how is that working out?

jesseylin commented 8 months ago

I only use the basic functionality AFAIK of julia-snail but it seems to work from my point of view. Thanks!