search

gdabah / distorm

Powerful Disassembler Library For x86/AMD64
Other
1.26k stars 238 forks source link

Python improvements #146

Closed akx closed 4 years ago

akx commented 4 years ago

The main points are really enumerated in the commit messages :)

I tried to keep changes nonintrusive for the time being – if Python 2 support is dropped (since it's EOL anyway), we could do nicer things with more modern syntax.

gdabah commented 4 years ago

@akx Thanks a lot for your precious contribution Aarni!!!

I didn't know yasm has a python module. I wrote one myself ten years ago and lost it and since then decided it's easier to invoke yasm.exe directly :) slow and ugly, but hey it works.

I will merge everything later on today.

That's curious why you happen to tend distorm?

gdabah commented 4 years ago

@akx How can we make sure that if the windows tests script fails it will affect the Actions? https://github.com/gdabah/distorm/runs/411214179?check_suite_focus=true

Meanwhile - Fixed the testing script and permissions of the yasm.exe.

akx commented 4 years ago

I didn't know yasm has a python module. I wrote one myself ten years ago and lost it and since then decided it's easier to invoke yasm.exe directly :) slow and ugly, but hey it works.

It doesn't, but at least the path is now configurable :)

That's curious why you happen to tend distorm?

I just happened to bump into it and figured I could help out :-)

How can we make sure that if the windows tests script fails it will affect the Actions? https://github.com/gdabah/distorm/runs/411214179?check_suite_focus=true

Huh, weird. I guess Powershell is confused about the ; syntax and doesn't end up returning the test script's error code to GHA.

gdabah commented 4 years ago

Okay cool I will check it out. I figured it’s the executable after I fixed a windows related problem with the temporary file.

Thanks again for all your contribution and help!

On Tue, Jan 28, 2020 at 08:45 Aarni Koskela notifications@github.com wrote:

I didn't know yasm has a python module. I wrote one myself ten years ago and lost it and since then decided it's easier to invoke yasm.exe directly :) slow and ugly, but hey it works.

It doesn't, but at least the path is now configurable :)

That's curious why you happen to tend distorm?

I just happened to bump into it and figured I could help out :-)

How can we make sure that if the windows tests script fails it will affect the Actions? https://github.com/gdabah/distorm/runs/411214179?check_suite_focus=true

Huh, weird. I guess Powershell is confused about the ; syntax and doesn't end up returning the test script's error code to GHA.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/gdabah/distorm/pull/146?email_source=notifications&email_token=AADMEWU2QLQQD6E2SXGUDHDQ77ICBA5CNFSM4KMAUWBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKCG7DY#issuecomment-579104655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADMEWVIXAXAADB24CJL3ODQ77ICBANCNFSM4KMAUWBA .