search

gdabah / distorm

Powerful Disassembler Library For x86/AMD64
Other
1.26k stars 238 forks source link

Provide a better way to get at OPERAND_MEMORY operands. #53

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This felt a little like I was delving too far into implementation details:

self.regs |= frozenset([distorm3.Registers[o.base]]) if 
distorm3.Registers[o.base] != None else self.regs
self.regs |= frozenset([distorm3.Registers[o.index]]) if 
distorm3.Registers[o.index] != None else self.regs

What do you think? I am not sure the user of the api should be aware of 
distorm3.Registers for example.

Original issue reported on code.google.com by vex...@gmail.com on 5 Sep 2012 at 3:18

GoogleCodeExporter commented 9 years ago 
Ok, provide a better suggestion then ;)

Original comment by distorm@gmail.com on 6 Sep 2012 at 3:49

GoogleCodeExporter commented 9 years ago 
Registers have their own representation and don't need to be touched directly 
in order to be displayed.

Original comment by distorm@gmail.com on 26 Jun 2013 at 6:23