gdamore / tcell

Tcell is an alternate terminal package, similar in some ways to termbox, but better in others.
Apache License 2.0
4.53k stars 306 forks source link

Should tcell.KeyTAB be tcell.KeyHT? #746

Open chrislalos opened 1 month ago

chrislalos commented 1 month ago

Firstly, tyvm for tcell :)

Looking at the section in key.go (https://github.com/gdamore/tcell/blob/88b9c25c3c5ee48b611dfeca9a2e9cf07812c35e/key.go#L426), it appears to be faithfully copied from an ASCII spec. I was curious about the origin, and various blogs led me to Wikipedia which led me to some US Armed Forces specs, specifically MIL-STD-188C and MIL-STD-188-100. key.go matches the specs perfectly, except for Tab, where the specs say HT but key.go has KeyTAB. key.go does specify KeyVT for Vertical Tab which matches the spec, so a change to KeyHT would be internally consistent as well. And then KeyTAB = KeyHT could be added to an aliases section.

Sound good?