Added a few comments on exceptions

gdanezis / petlib

A python library that implements a number of Privacy Enhancing Technolgies

BSD 2-Clause "Simplified" License

130 stars 33 forks source link

Added a few comments on exceptions #6

Closed The-Skas closed 8 years ago

The-Skas commented 8 years ago

Comments clarifying that: the method quick_gcm_dec throws an exception, and the method finalize throws an exception on an invalid tag.

gdanezis commented 8 years ago

Nice one!

Can you instantiate the "key" variable (presumably to urandom(16)) in the pydoc, so that the fragment is actually valid (and all the petlib tests pass). Currently the test for "finalize" fails, as a result to the unknown variable "key" on line 248 :-)

The-Skas commented 8 years ago

Oops Sorry. Not sure what test is failing. I just found the yaml script, will try running it.

gdanezis commented 8 years ago

Tidied up a bit the actual exception thrown by "dec", and fixed the docstring. Nice work!