search

gdborton / webpack-parallel-uglify-plugin

A faster uglifyjs plugin.
466 stars 34 forks source link

how to disable sourcemap? #14

Closed feibyte closed 7 years ago

gdborton commented 7 years ago

Sourcemaps should be respecting the devtool option in your webpack config. Are you seeing otherwise?

feibyte commented 7 years ago

@gdborton it works. but I won't change devtool because I want to keep scss sourcemap.

derekdon commented 7 years ago

@gdborton It's fairly standard not to set devtool if you're using the SourceMapDevToolPlugin directly. Is there a way to tell the plugin to use/keep sourcemaps in such cases? Perhaps setting devtool to some non actionable truthy string is enough for it to not conflict with SourceMapDevToolPlugin and work with this plugin... however I'll need to test it. I suspect the devtool prop will be removed at some point in the future, perhaps wp3.

gdborton commented 7 years ago

I'll be honest, I had no idea that plugin even existed. I'll take another look at the interop and see about updating this plugin.

derekdon commented 7 years ago

@gdborton Yeah basically your devtool string is converted into an instance of it or the eval version under the hood. See https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L212. When you need more control you can just use it directly and omit the devtool setting.

gdborton commented 7 years ago

@fedeoo @derekdon This has been fixed in the 1.0.0 release. Source maps are now controlled via the sourceMap boolean in the plugin's options.

I'll leave this issue open for a little while longer to address any remaining issues you may have.