Don't prune the cache while unoptimized assets exist

gdborton / webpack-parallel-uglify-plugin

A faster uglifyjs plugin.

466 stars 34 forks source link

Don't prune the cache while unoptimized assets exist #41

Closed GoodForOneFare closed 6 years ago

GoodForOneFare commented 7 years ago

Plugins like extract-text-webpack-plugin may cause multiple optimize-chunk-assets callbacks. This means that the uglify cache is often deleted before webpack gets around to uglifying actual JS chunks :/

Waiting for the done event guarantees that all chunks are processed before pruning the cache.

coveralls commented 7 years ago

Coverage decreased (-2.0%) to 91.667% when pulling 09be30a281747a6519bcd0fd51e8a304f487fe67 on GoodForOneFare:prune-cache-after-compilation into 39fdb2591e11648e7d434bfdcad410a02c623b3a on gdborton:master.

coveralls commented 7 years ago

Coverage increased (+3.6%) to 97.222% when pulling 4130c51a7196b6d4e884ba8a7f17e79cfe968011 on GoodForOneFare:prune-cache-after-compilation into 39fdb2591e11648e7d434bfdcad410a02c623b3a on gdborton:master.

GoodForOneFare commented 7 years ago

@gdborton could you take a look at this PR, please? Thanks for the awesome plugin!

gdborton commented 6 years ago

Seems legit, thanks for the contribution! (sorry for the delay)