search

gdcc / dataverse-ansible

Ansible role for installing Dataverse
GNU General Public License v3.0
18 stars 21 forks source link

DD-1651: m4a files are not recognized as mpeg/audio by Dataverse #375

Closed jo-pol closed 1 month ago

jo-pol commented 1 month ago

how to test

start-preprovisioned-box.py -s

upload files to a dataset: sample3 from https://toolsfairy.com/tools/audio-test/sample-mp3-files# and https://toolsfairy.com/tools/audio-test/sample-m4a-files#

save the dataset changes, only the mp3 will have a previewer

execute the curl command, revisit the dataset/file page, both files will have a previewer on both files

qqmyers commented 1 month ago

@jo-pol - you could add m4a to https://github.com/gdcc/dataverse-previewers/blob/develop/6.1curlcommands.md as well if you want.

donsizemore commented 1 month ago

If you don't want it merged I can revert it, but your PR was to Dataverse-Ansible where it's merely the addition of a curl call.

You probably want to track browser testing in the dataverse-previewers repo?