add NcML previewer #17 - Githubissues

gdcc / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse

MIT License

5 stars 15 forks source link

add NcML previewer #17 #18

Closed pdurbin closed 1 year ago

pdurbin commented 1 year ago

Closes #17

Here's a screenshot of how it looks:

Screen Shot 2022-12-20 at 2 26 47 PM

pdurbin commented 1 year ago

Because I can't put this PR on https://github.com/orgs/IQSS/projects/2 I'm using the following issue to represent its state:

https://github.com/IQSS/dataverse/issues/9242

I'm about to move it back to review since I believe I've addressed the feedback so far.

While I'm here I'll leave a screenshot of the expected error page, which I was just testing:

Screen Shot 2022-12-22 at 11 46 13 AM

qqmyers commented 1 year ago

Looks good. The XSS filtering might be more than needed (i.e. the html previewer filters much less than the text previewer), but that can be adjusted as people play with real NetCDF files and decide what's useful.