Add ELN based on the Zip previewer

NicolasCARPi commented 1 year ago

Hello,

As discussed here, this PR adds support for ELN archive. An ELN archive is a zip file so the Zip previewer will work.

A few notes:

I have not tested this. You can download a .eln example here.
The file has windows line endings, can I make another PR after running dos2unix on it?
The file has no headers/sections, I think it would help to have headers about the file type to improve readability.
I'm targeting the develop branch because I'm guessing that's the correct branch to target, but a CONTRIBUTING.md file to help new contributors would be great.
I have kept the toolname as ZipPreviewer, I'm not sure if it has to be changed or not, being unfamiliar with the codebase. Please advise.

Best, ~Nico

pdurbin commented 1 year ago

I played with it over at https://dev1.dataverse.org/dataset.xhtml?persistentId=doi:10.5072/FK2/TL5MYW and it looks good and seems to work fine.

The only weird thing I noticed is the word "footer" in the bottom right.

Screenshot 2023-02-13 at 06-48-40 wet lab Screenshot 2023-02-13 at 06-49-09 single-experiment eln - Root

NicolasCARPi commented 1 year ago

The only weird thing I noticed is the word "footer" in the bottom right.

I believe this is due to these lines: https://github.com/gdcc/dataverse-previewers/blob/d8193b1083d0b84443303fc345d8d6d5e12d9f04/previewers/betatest/js/retriever.js#L191-L192

No idea what is their purpose!

haarli commented 1 year ago

The word "footer" is displayed on every preview page, not only for the Zip Previewer. Don't know about the original intention, so I haven't made any changes here. Maybe it's only a label which is missing?

NicolasCARPi commented 1 year ago

Don't know about the original intention

yeah it's peculiar, but I'd remove it. git blame doesn't help because it was all added at same time so history is lost.

gdcc / dataverse-previewers

Add ELN based on the Zip previewer #21