search

gdcc / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
5 stars 15 forks source link

Footer not displayed in some previews #44

Open stevenferey opened 8 months ago

stevenferey commented 8 months ago

Hello,

We observed a fault in the display of the footer which is visible in some previews. For example, an image and a pdf of the Dataverse demo portal :

The content of the footer is not loaded, the name of the property is directly displayed, , linked to the code: https://github.com/gdcc/dataverse-previewers/blob/develop/previewers/v1.3/js/retriever.js#L191

Capture d’écran du 2023-12-06 17-00-32

If you explore the document in a separate browser tab, the footer is displayed correctly :

Capture d’écran du 2023-12-06 17-01-14

This problem was observed on versions 5.12.1+ of Dataverse Browsers tested: Firefox and Brave

Thanks

qqmyers commented 7 months ago

This appears to be fixed in v1.4 (I tested with Dataverse 6.1, but I don't think the Dataverse code should be involved in this.) I don't think there was a specific fix for this but the timing of when the i18n functionality was initialized changed which could be what's needed. If you still see this with v1.4, let us know.