search

gdcc / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
5 stars 15 forks source link

reduces max video width to match iframe width #61

Closed gwendoux closed 3 months ago

gwendoux commented 3 months ago

when the video is too wide, it is not displayed in its entirety. By adjusting the maximum width of the preview, you can display the video more gracefully.

3467bab7c8ce7e9c241f2b4ea6e9aeeeb971ead23b3dea80c41bc7b4de6a2dd3

gwendoux commented 3 months ago

Oh thanks, I did miss that one

qqmyers commented 3 months ago

By policy, we don't change prior versions - a normal restriction and more important since they may be used live from github.io by various installations. If this can be changed to be a betatest-only PR, we can merge it. (And consider a v1.5 release when this and some other PRs are finished).

gwendoux commented 3 months ago

it's understandable, I make the modification only on betatest It seemed odd to me afterwards that there was so much redundancy for a single modification.

gwendoux commented 3 months ago

@qqmyers I cleaned up the pull-request. Thanks