gdcc / dataverse-previewers

A collection of Datafile Previewers that can be configured to work with Dataverse
MIT License
5 stars 15 forks source link

Testing 3D previewer (X_ITE) #68

Open Cook4986 opened 3 months ago

Cook4986 commented 3 months ago

@pdurbin Here's a range of HL models with problems that we can use for further 3D previewer testing:

Note: I've confirmed these X3D models are rendering correctly in both Meshlab and Blender (v3.3).

Any ideas about the missing geometry, @PaulBoon? @landreev, would you mind "putting some configuration settings in place on the Dataverse end" to enable .obj and/or .gltf format(s) previewing, to compare (should be supported as per pull request #56)?

PaulBoon commented 3 months ago

@Cook4986 , @landreev , Sorry for the late reply. When I used the wording 'initial implementation' I was hoping others would pick it up and improve wherever possible. Without having tried to improve rendering I would like to warn for optimizing on specific models, better make something into a menu option instead of a default. Also it might be impossible to get a previewer that works good for every model you throw at it, so we might have to decide what is good enough or how we can have it 'fail' gracefully.

PaulBoon commented 3 months ago

@Cook4986 Great examples. Loading takes a long time, at first just a black canvas, then a 'loading 1 file' without much of a progress indication. Not sure what it is, but depending on the angle surfaces seem to vanish, so maybe something goes wrong with the surface normals. Maybe Meshlab can give a clue?

BTW I just opened it in Meshlab and it looks ok, only the bottom part of the book is 'open', makes sense because that was probably occluded when scanning, but at least that is not going wrong in the previewer. Screenshot from 2024-06-18 17-28-22