search

gdcc / dv-metrics

Visualize metrics for a Dataverse installation and its collections
Apache License 2.0
2 stars 2 forks source link

Upgrade dependencies; use latest libraries where possible #5

Open PaulBoon opened 1 year ago

PaulBoon commented 1 year ago

If we don't upgrade we potentially miss out on improvements and important fixes.

Currently the following libs are used:

The latest (at time of writing) are:

PaulBoon commented 1 year ago

Upgrade of jquery was simple, replacing with 3.7.0 seemed to work 'out-of-the-box'.

    <script src="https://code.jquery.com/jquery-3.7.0.min.js">
    </script>

However, Bootstrap did not go as well. Versions 5.x and 4.x seem to give problems with our use of the gridlayout. This should be investigated.

Upgrading to the latest 3.x; 3.4.1. did work. 

<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/css/bootstrap.min.css" integrity="sha384-HSMxcRTRxnN+Bdg0JdbxYKrThecOKuH5zCYotlSAcp1+c8xmyTe9GYg1l9a69psu" crossorigin="anonymous">
<script src="https://cdn.jsdelivr.net/npm/bootstrap@3.4.1/dist/js/bootstrap.min.js" integrity="sha384-aJ21OjlMXNL5UyIl/XNwTMqvzeRMZH2w8c5cRVpzpU8Y5bApTppSuUkhZXN0VxHd" crossorigin="anonymous"></script>
PaulBoon commented 1 year ago

JQTree 1.7.0, from https://mbraak.github.io/jqTree was working fine. Did also move that to a version specific directory. 

    <script src="jqtree.1.7.0/tree.jquery.js">
    </script>

and 

    <link href="jqtree.1.7.0/jqtree.css" media="screen" rel="stylesheet" type="text/css">

Removed the bottom line of the js file, referencing the 'map', only used for debuggin.

PaulBoon commented 1 year ago

First attempt to upgrade d3plus has not been successful. Seems that the change from v1 top v2 needs a considerable rewrite. We already use the latest 1.x version; 1.9.8. We might consider to keep it for a while. BTW I tried using these: 

<script src="https://cdnjs.cloudflare.com/ajax/libs/d3/7.8.5/d3.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/d3plus/2.1.1/d3plus.min.js"></script>
PaulBoon commented 1 year ago

Upgrading to bootstrap 5.3.0 was not simple, a lot changed; cards instead of panels, no glypicons and collaps was different. This page was helpful: https://getbootstrap.com/docs/4.0/migration/

PaulBoon commented 1 year ago

The d3plus upgrading/migration is diificult, because of lack of documentation and examples that are usefull. Upgrading was an issue before: https://github.com/IQSS/dataverse-metrics/issues/69

Looks like we could have a separate PR for just the d3plus upgrade.