search

gdcc / dvwebloader

A web tool for uploading folders of files to a Dataverse dataset
Apache License 2.0
1 stars 6 forks source link

#8 adding link to dataset on success and handling parameters in language keys #22

Open luddaniel opened 10 months ago

luddaniel commented 10 months ago

This PR includes :

UI Screenshot : 8-adding-link-to-dataset-on-success

qqmyers commented 9 months ago

@luddaniel - thanks for the PR. While I can see the issue that people may not read/follow the instructions and not know how to see their new files, I'm not sure that opening another copy of the dataset window is the best solution (the way things work now, the old dataset window still exists, so the user's browser would now have one view with their files and an older one without.)

Would it be good enough to make 'close this window' a link that would indeed close the window? And/or to change the text/styling to make it much clearer that 'To see your new files, 1) close this window, and 2) refresh your dataset page'.

If not, I'd like to request that the change your making be configurable (or only shown when using Dataverse <=v5.12? - since that is when refreshing the existing dataset window causes the dvwebloader to be launched again) as I think some sites will not want to have more windows popping up.

FWIW: At least parts of #8 are obsolete/only affect older versions (<=5.12) of Dataverse - with the dvwebloader integrated into the upload pane, refreshing the existing dataset window does not try to re-launch the dvwebloader.