search

gdcc / easyDataverse

🪐 - Lightweight Dataverse interface in Python to upload, download and update datasets found in Dataverse installations.
MIT License
15 stars 4 forks source link

add hdf5 requirement for macOS #5

Open atrisovic opened 1 year ago

atrisovic commented 1 year ago

I needed to install it, but I'm not sure if there is a better way to avoid it. This PR is just a suggestion.

JR-1991 commented 1 year ago

I think HDF5 is an edge case and most users will probably stick to the other formats that are supported, if they even utilize the export/import. Requiring HDF5 by default may be less helpful as one might not want to install the HDF5 lib.

In addition to the text you've added, I'd suggest providing it as an extra dependency if wished and to import it when needed. Users then may install it like this:

pip install easydataverse["hdf5"]

What do you think?