search

gdcc / pyDataverse

Python module for Dataverse Software (dataverse.org).
http://pydataverse.readthedocs.io/
MIT License
63 stars 41 forks source link

fix newer dataverse compatibility by adding content-type=application/json header #145

Closed pallinger closed 1 month ago

pallinger commented 2 years ago

fix newer dataverse compatibility by adding content-type=application/json header

Changes:

based on https://github.com/JR-1991/pyDataverse/commit/0fcfcd3fbc6bf1aec869899f715a51dca25e91be

Closes #143

pallinger commented 1 year ago

Could someone review this?

skasberger commented 1 year ago

Update: I left AUSSDA, so my funding for pyDataverse development has stopped.

I want to get some basic funding to implement the most urgent updates (PRs, Bug fixes, maintenance work). If you can support this, please reach out to me. (www.stefankasberger.at). If you have feature requests, the same.

Another option would be, that someone else helps with the development and / or maintenance. For this, also get in touch with me (or comment here).

JR-1991 commented 1 year ago

Could someone review this?

Sorry for the delay! Thanks for converting this into a PR 👍 Reviewing now!

JR-1991 commented 1 year ago

@pallinger can you sync your branch to the latest commit so it isn't out-of-date?

JR-1991 commented 1 year ago

@pallinger thanks for syncing! I'll test it and check with @skasberger about the two checks that need to be run.

pdurbin commented 12 months ago

Could this be related?

JR-1991 commented 12 months ago

@pdurbin yes this PR will resolve the error. Had the same issue a while back and adding the content-type fixed it. Shall we merge this PR then? The changes shouldn't break anything.

pdurbin commented 11 months ago

@JR-1991 I haven't tested it but if you're happy, I'm happy! 😜

sonarcloud[bot] commented 7 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pdurbin commented 1 month ago

@pallinger good news! As @JR-1991 says in this comment, the switch to httpx fixed this: https://github.com/gdcc/pyDataverse/issues/143#issuecomment-2104513723

I'll go ahead and close this pull request.

By the way, if you haven't heard, we have regular pyDataverse meetings now. You're welcome to join! Please see https://py.gdcc.io . We're also on Zulip: https://dataverse.zulipchat.com/#narrow/stream/377090-python