search

gdcc / pyDataverse

Python module for Dataverse Software (dataverse.org).
http://pydataverse.readthedocs.io/
MIT License
64 stars 45 forks source link

get_request params get overwritten #85

Open skasberger opened 3 years ago

skasberger commented 3 years ago

Bug report

In pyDataverse.api, the get_request() function call does not use params, as it gets overwritten with params = {} in the first line.

1. Describe your environment

2. Actual behaviour:

Passed params attributes get lost.

3. Expected behaviour:

Passed params should have changed the request function.

4. Steps to reproduce

Viewed the code.

5. Possible solution

sergejzr commented 1 year ago

Dear pyDataverse community, the issue is still existing. Could you tell, what is planned the strategy in this regard? For example, I need to ignore the certificate check on the test server through params, but this is not possible because params get overwritten.

skasberger commented 1 year ago

Update: I left AUSSDA, so my funding for pyDataverse development has stopped.

I want to get some basic funding to implement the most urgent updates (PRs, Bug fixes, maintenance work). If you can support this, please reach out to me. (www.stefankasberger.at). If you have feature requests, the same.

Another option would be, that someone else helps with the development and / or maintenance. For this, also get in touch with me (or comment here).

pdurbin commented 7 months ago

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python