gdcc / pyDataverse

Python module for Dataverse Software (dataverse.org).
http://pydataverse.readthedocs.io/
MIT License
63 stars 41 forks source link

Remove curl dependency #88

Open skasberger opened 3 years ago

skasberger commented 3 years ago

Remove curl dependency from pyDataverse, which is coming from replace_datafile().

Prepare

Implementation

Review

Follow-Ups

bpoldrack commented 1 year ago

Would like to upvote this and mention that:

  1. As far as I can tell, it's not replace_datafile, but update_datafile_metadata.
  2. Not only does it cause this dependency, but it makes update_datafile_metadata a strange exception with respect to its return value, which is a CompletedProcess object. So, not only not a Response like everywhere else, but also not "The json string responded by the CURL request, converted to a dict()" as the docstring reads.
pdurbin commented 4 months ago

As discussed during the 2024-02-14 meeting of the pyDataverse working group, we are closing old milestones in favor of a new project board at https://github.com/orgs/gdcc/projects/1 and removing issues (like this one) from those old milestones. Please feel free to join the working group! You can find us at https://py.gdcc.io and https://dataverse.zulipchat.com/#narrow/stream/377090-python