gdcodeclub / nedry

MIT License
2 stars 1 forks source link

As a user I want to have nedry send an email to the individual's computer. #11

Closed gsaarinen closed 8 years ago

lpillman commented 8 years ago

Jim and I are interested in taking a look at this one.

eebbesen commented 8 years ago

http://guides.rubyonrails.org/action_mailer_basics.html

lpillman commented 8 years ago

@eebbesen couldn't we use the TMS client instead? http://www.rubydoc.info/gems/govdelivery-tms/0.8.9. Is the mailer another way to do this?

lpillman commented 8 years ago

Jim: We needed to write the test first.

To your questions tho:

  1. Yes, we do need to require the gem at the top.
  2. Do we need to create a separate file? Or can we include it the offense controller? We can include it right in the offense controller since our code is going to pretty small.
kmarekspartz commented 8 years ago

@edlebert has talked about making a TMS Client strategy for ActionMailer, so if you use ActionMailer now, you may be able to switch to TMS Client later with a small amount of configuration.

lpillman commented 8 years ago

That is interesting @zeckalpha. Jim and I want to have an excuse to use the TMS mailer gem so I think we will be using that directly. It is too bad more clients don't use ruby for a programming language. Your documentation seems pretty extensive.

lpillman commented 8 years ago

Still to do:

richardgfong commented 8 years ago

Thing to think about (out of scope right now):

lpillman commented 8 years ago

I have added the Heroku Config Var of TMS_TOKEN with the actual token.

richardgfong commented 8 years ago

Try adding tms_token to my BASH profile

beja0502 commented 8 years ago

Added Email/SMS and tests