search

gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android
https://pub.dev/packages/alarm
MIT License
132 stars 86 forks source link

Removed package attribute and add namespace property #130

Closed tattuu closed 10 months ago

tattuu commented 10 months ago

The content written in this issue (https://github.com/gdelataillade/alarm/issues/86) seems to have occurred due to the Android Gradle Plugin(AGP) version being 8 or higher.

Therefore, I have made changes to adapt to Gradle 8 and above.

Reference Materials:

  1. https://github.com/ionic-team/capacitor/issues/6504
  2. https://bps-tomoya.hateblo.jp/entry/2022/05/11/193325
  3. https://developer.android.com/studio/build/configure-app-module?hl=ja#set-namespace
gdelataillade commented 10 months ago

Hi @tattuu

Thanks for your PR !

Unfortunately, I tested my alarm example app with your changes and alarms did not trigger... Is there something more to change ? Looks like my native services were not found. No error logs in the debug console.

gdelataillade commented 10 months ago

What Gradle version and what Java version are you using ?

tattuu commented 10 months ago

Hi @gdelataillade

I apologize for the delayed response.

I've created a new pull request (https://github.com/gdelataillade/alarm/pull/139) that includes the modifications in the 'example' directory and addresses several missing commits from the previous submission.

I generated the pull request based on the latest state of the main branch and have already conducted testing to ensure functionality.

I appreciate your multiple reviews, and I apologize for any inconvenience.

If you could please check the latest pull request, I would be grateful.