Feature/prevents int type error

gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android

https://pub.dev/packages/alarm

MIT License

132 stars 86 forks source link

Feature/prevents int type error #145

Closed Raonshi closed 9 months ago

Raonshi commented 9 months ago

Why this PullRequest is needs

When i make AlarmSettings model, I set id to timestamp of DateTime.now(). It works on iOS, but doesn't work on Android. So, to prevent this case, I added some assertions in AlarmSettings model.

Changes

Add two assertion in AlarmSettings model.
- assert(id != 0 && id != -1, "id cannot be set to 0 or -1")
- assert(id <= 2147483647, "id cannot be set larger then Android Int.MAX_VALUE")
Add example case

gdelataillade commented 9 months ago

Hi @Raonshi

Thank you so much for your PR !

Sounds good, let me know when you're done and I'll review it and merge it.

Raonshi commented 9 months ago

@gdelataillade actually, i'm already done that. in this PR, you can see two assertions in AlarmSettings model.

this PR supports developer to prevent using big number in id of AlarmSettings at debug mode.

gdelataillade commented 9 months ago

@Raonshi

Awesome, I merge it and it will be available in the next release ! Thanks for your contribution !