gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android
https://pub.dev/packages/alarm
MIT License
132 stars 86 forks source link

Make use of Hive over SharedPreferences; make the Alarm class abstract and final, or singleton #210

Closed ShadichyDev closed 1 month ago

ShadichyDev commented 5 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] Hive is much more efficient and strictly typed than SharedPreferences. You should consider moving to Hive Also, the Alarm class sometimes confuses me with the (). Simple workaround is to make it 'abstract final', or make it singleton class

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

gdelataillade commented 5 months ago

Hi @ShadichyDev

I use hive in my other projects and I think the package is awesome but I chose shared_preferences for the following reasons:

I'm open to discussion, and if you change my mind I will do the migration.