search

gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android
https://pub.dev/packages/alarm
MIT License
132 stars 86 forks source link

[ios] After cancelling the alarm with Alarm.stopAlarm the vibration still goes through. #22

Closed freakness closed 1 year ago

freakness commented 1 year ago

The sound and notification are cancelled correctly but the vibration still starts at the specified time.

I believe the below line might be the issue. The vibrate boolean is overwritten when the timeout is reached.

https://github.com/gdelataillade/alarm/blob/6276b15a43104cf5a73f35a42fe3c1940b4d48d7/ios/Classes/SwiftAlarmPlugin.swift#L103

gdelataillade commented 1 year ago

Hi @freakness

Thanks for reporting the issue. I'll fix it very soon.

freakness commented 1 year ago

Hi @gdelataillade

I would do it myself, but I'm not that versed in swift. Thanks for responding quickly, we disabled vibration for now.

gdelataillade commented 1 year ago

No problem. I'll let you know when it's fixed.

gdelataillade commented 1 year ago

Hi @freakness

I've fix the issue and updated the plugin to 0.2.5. Please update the dependency and let me know if everything is working as expected.

freakness commented 1 year ago

This fixes the issue for me. Thank you for the quick fix! Closing the issue.