search

gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android
https://pub.dev/packages/alarm
MIT License
132 stars 86 forks source link

Add tests for fadeDuration and isRinging to example app #272

Closed orkun1675 closed 3 weeks ago

orkun1675 commented 3 weeks ago

These changes should help facilitate the testing of:

gdelataillade commented 3 weeks ago

Thanks @orkun1675

gdelataillade commented 3 weeks ago

@orkun1675 I have been experimenting with the example app and I sometimes have a dark screen when I stop the alarm, like navigation popped twice.

orkun1675 commented 2 weeks ago

@gdelataillade my new PR addresses that issue by delegating popping the route to the isAlarmRining listener. See changes here: https://github.com/gdelataillade/alarm/pull/276/files#diff-00e21ecc08249d9a653eb5404d795049cd40298d41930d9e140d3796d143b423R53

The Snooze/Stop buttons no longer pop the route.