gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android
https://pub.dev/packages/alarm
MIT License
132 stars 86 forks source link

Enable custom time zone selection for notifications #45

Closed r0227n closed 1 year ago

r0227n commented 1 year ago

Allow the TimeZoneId to be freely set, enabling the notification time zone to be customized. Currently, the time zone is fixed to UTC, which makes it inconvenient to use, so I made this modification."

gdelataillade commented 1 year ago

Hi @r0227n

Thanks for your work ! I'm not sure to understand very well the issue though. You had issues with the time the notification is shown ? It is supposed to be scheduled according to the local time of the device.

r0227n commented 1 year ago

@gdelataillade I'm sorry, it was my mistake. The notifications are working correctly now.

Could you help me with something? Is it intentional that notifications don't appear when the app is running? I would like to have notifications displayed even when the app is active, in addition to the alarm sound.

https://user-images.githubusercontent.com/40818362/235159100-25d67ccd-9fdd-4450-bdb6-79bfeaff2b0b.mp4

gdelataillade commented 1 year ago

Hi @r0227n

Yes it was intentional that the notification does not appear when app is on foreground. I thought it was not especially relevant to show a notification. However, if you convince me, I can change it.

r0227n commented 1 year ago

Thank you @gdelataillade I understand that it's not possible to show a notification when the app is in the foreground. Since a specific action can be taken when the time comes, I don't think it's a problem.

Close this PR.