Alarm.isRinging forgot to add OS check and missing android function

gdelataillade / alarm

A Flutter plugin to easily manage alarms on iOS and Android

https://pub.dev/packages/alarm

MIT License

132 stars 86 forks source link

Closed whowillcare closed 11 months ago

whowillcare commented 1 year ago

Alarm plugin version version 1.1.7

Describe the bug function in alarm.dart, line: 164, it only checks IOSAlarm

To Reproduce

gdelataillade commented 1 year ago

Hi @whowillcare,

Thanks for opening this issue. I'll add the android check as soon as possible and I'll keep you updated !

gdelataillade commented 1 year ago

Hi @whowillcare,

I added the method for Android and updated the plugin to 1.1.8.

Please update the plugin in your project and let me know if it works as expected.

whowillcare commented 1 year ago

It does seem to work now. However, the newest version has introduced new bug.

whowillcare commented 1 year ago

With deeper test, and I found even when Alarm was really ringing, the return was still false somehow for android, iOS was fine. thanks

gdelataillade commented 1 year ago

I was not able to reproduce this issue.

What is your use case for the isRinging method ? Have you consider using ringStream ? I was thinking deprecating isRinging, what do you think ?