gdemin / excel.link

Convenient Data Exchange between R and Microsoft Excel
56 stars 16 forks source link

Make deconstructor virtual #3

Closed jimhester closed 8 years ago

jimhester commented 8 years ago

Fixes a GCC warning and linking error from gcc v4.9.3

RCOMObject.h: In member function 'virtual ULONG RCOMObject::Release()': RCOMObject.h:72:50: warning: deleting object of abstract class type 'RCOMObject' which has non-virtual destructor will cause undefined behaviour [-Wdelete-non-virtual-dtor] delete this;

Windows R will be migrating to the 4.9.3 toolchain with the upcoming release on May 3rd, so this fix should be sent to CRAN very soon.

gdemin commented 8 years ago

Thank you for fix.