android: fixed errors reported in the lint test

gdesmott / manger-veggie

GNU Affero General Public License v3.0

5 stars 4 forks source link

android: fixed errors reported in the lint test #20

Open drzraf opened 8 years ago

drzraf commented 8 years ago

showAsAction namespace
minSdkVersion == 14 since parent="android:Theme.Holo.Light.DarkActionBar" (src/main/res/values/styles.xml) is not available before

and a couple of lint warnings:

SetJavaScriptEnabled is legitimate
before in app/src/main/AndroidManifest.xml

gdesmott commented 8 years ago

@rberiot : can you review this please?

rberiot commented 8 years ago

@drzraf is there a reason in our case to use parent="android:Theme.Holo.Light.DarkActionBar" as we are currently just wrapping a fullscreen webview? bumping the API level from 10 to 14 means we only android 4.0+ instead of 2.3.3+

drzraf commented 8 years ago

I don't know, sorry (I've a reduced knowledge and interest in Android)

gdesmott commented 8 years ago

Yeah ideally it would be bettter to use an older theme so we don't have to bump the dep.

drzraf commented 8 years ago

just a ping about this one, since it's old, is an easy one and is a preliminary step before thinking into having a vegoresto-app (or extending manger-veggie's app)

gdesmott commented 8 years ago

The maintainer of the Android app, @rberiot, on holidays atm so he won't have be able to look at it for now.

Any chance you could take a look and check if using an older theme would fix the warning as well?

drzraf commented 8 years ago

I'm pretty sure that yes (cf lint log), but I'm not knowledgeable enough to make and test the change. ping @rberiot again.