search

gdesmott / system-deps

Run pkg-config from declarative dependencies in Cargo.toml
Apache License 2.0
89 stars 21 forks source link

Removing dependencies #49

Closed GuillaumeGomez closed 3 years ago

GuillaumeGomez commented 3 years ago

Someone opened an issue on gtk-rs https://github.com/gtk-rs/gtk-rs-core/issues/225 about the fact that this crate was problematic because it weighted heavily on the build process. Would you be open for me to remove dependencies (while keeping the same features!)?

gdesmott commented 3 years ago

I'm still not convinced that build specific dependencies are that much of a problem tbh. That said I may consider simple changes providing they significantly reduce the dependencies tree while not increasing the code complexity or maintenance burden.

Do you know about such potential changes?

GuillaumeGomez commented 3 years ago

I opened #50. To answer you, the biggest problem with your crate using a lot of dependencies is that it's used in a lot of places. Now about the dependencies, they have two issues: they need to be downloaded and to be built. And as you know, proc-macro are quite "heavy" on compile-time.

sdroege commented 3 years ago

that it's used in a lot of places

Because of that it's also less of a problem because you only build it once :)