search

gdesmott / system-deps

Run pkg-config from declarative dependencies in Cargo.toml
Apache License 2.0
87 stars 21 forks source link

Sort dependencies before using them #56

Closed kanavin closed 2 years ago

kanavin commented 2 years ago

Otherwise they come out in non-reproducible order, and that order leaks into target binaries.

Signed-off-by: Alexander Kanavin alex@linutronix.de

gdesmott commented 2 years ago

Makes sense, thanks for your patch.

Can you please fix the CI and then I'll merge?

kanavin commented 2 years ago

Makes sense, thanks for your patch.

Can you please fix the CI and then I'll merge?

Should be fixed now.

kanavin commented 2 years ago

Ok, now I did locally run the build, the tests, and rustfmt on the code, hope this should be enough :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #56 (a1aab65) into master (e470dc0) will decrease coverage by 0.38%. The diff coverage is 91.66%.

:exclamation: Current head a1aab65 differs from pull request most recent head 12feaae. Consider uploading reports for the commit 12feaae to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   77.67%   77.29%   -0.39%     
==========================================
  Files           3        3              
  Lines        2611     2620       +9     
==========================================
- Hits         2028     2025       -3     
- Misses        583      595      +12
Impacted Files Coverage Δ
src/lib.rs 59.80% <90.90%> (-0.63%) :arrow_down:
src/test.rs 98.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e470dc0...12feaae. Read the comment docs.

gdesmott commented 2 years ago

Looks like clippy isn't happy now.

kanavin commented 2 years ago

Looks like clippy isn't happy now.

Just fixed.

gdesmott commented 2 years ago

I just published 6.0.0 with your patch, thanks!

kanavin commented 2 years ago

I just published 6.0.0 with your patch, thanks!

:+1: