gdesmott / system-deps

Run pkg-config from declarative dependencies in Cargo.toml
Apache License 2.0
87 stars 21 forks source link

Add fallback names to probe to account for platform differences #73

Closed de-vri-es closed 1 year ago

de-vri-es commented 1 year ago

This PR adds support for fallback-names to allow dealing with different names on different platforms. It also updates the documentation and adds tests. The user can specify fallback-names directly on the dependency entry, and on the version overrides.

gdesmott commented 1 year ago

Thanks for the patch! I think that makes sense.

Can you please fix formating by running cargo fmt?

codecov[bot] commented 1 year ago

Codecov Report

Merging #73 (fe7e49c) into master (637d47f) will increase coverage by 1.87%. The diff coverage is 98.66%.

:exclamation: Current head fe7e49c differs from pull request most recent head 297b01c. Consider uploading reports for the commit 297b01c to get more accurate results

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   60.40%   62.28%   +1.87%     
==========================================
  Files           3        3              
  Lines        3324     3500     +176     
==========================================
+ Hits         2008     2180     +172     
- Misses       1316     1320       +4     
Impacted Files Coverage Δ
src/lib.rs 38.45% <96.22%> (+0.09%) :arrow_up:
src/metadata.rs 90.60% <98.94%> (+2.12%) :arrow_up:
src/test.rs 98.50% <100.00%> (+0.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

de-vri-es commented 1 year ago

Thanks for the quick review!

Can you please fix formating by running cargo fmt?

Whoops, done :)

gdesmott commented 1 year ago

I just published 6.1.0 with this new feature.

de-vri-es commented 1 year ago

Thanks!