gdesmott / system-deps

Run pkg-config from declarative dependencies in Cargo.toml
Apache License 2.0
87 stars 21 forks source link

Honor manual requests for static linking #75

Closed Ablu closed 1 year ago

Ablu commented 1 year ago

This allows a user to statically link a library even when not using pkg-config as source. Previously, if SYSTEMDEPS_NO_PKG_CONFIG was set, the SYSTEMDEPS_LINK=static configuration was ignored.

Since the user already went above and beyond to issue a strong intent of static linking, no check is performed whether the file actually exists. The linker will scream if something is wrong.

codecov[bot] commented 1 year ago

Codecov Report

Merging #75 (0b30a14) into master (d1765d9) will increase coverage by 0.49%. The diff coverage is 98.18%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   62.48%   62.97%   +0.49%     
==========================================
  Files           3        3              
  Lines        3505     3565      +60     
==========================================
+ Hits         2190     2245      +55     
- Misses       1315     1320       +5     
Impacted Files Coverage Δ
src/lib.rs 38.86% <90.00%> (+0.20%) :arrow_up:
src/test.rs 98.57% <100.00%> (+0.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gdesmott commented 1 year ago

Thanks for your patch, and kudo for writing a test! :heart:

I just released 6.1.1 with it.

Ablu commented 1 year ago

I just released 6.1.1 with it.

Thanks :)