search

gdevanla / haskell-lox

Other
5 stars 1 forks source link

review #3

Open santiweight opened 3 years ago

santiweight commented 3 years ago

Just a note:

this parser likely doesn't need a lexer. Looks like it is very expressable as a director parser combinator, which would be the common way to do this. Obviously, if you're following a book I understand

gdevanla commented 3 years ago

@santiweight Thanks a lot for the feedback. Those are very valuable comments and helps me learn how to write better parsers.

If you don't mind can I just pick and choose pieces of your PR and then commit it myself. I kind of want to maintain a theme for the blog and keep things closer to the book and therefore I have made some choices which my not entirely align with Haskell style.