search

gdg-tangier / vue-firestore

:cloud: Cloud Firestore binding in realtime with Vuejs
MIT License
235 stars 28 forks source link

Avoid no promise resolve if collection doesn't exist #5

Closed Jaimeer closed 6 years ago

Jaimeer commented 6 years ago

If the collection doesn't exists the promise is never resolve


source.onSnapshot(
    doc => {
      debug('collections', 'doc', doc)
      doc.docChanges.forEach( // <-- No enter
        snapshot => {
          ...
          resolve(container) // <-- No call
        },
        error => {
          reject(error)
        }
      )
      resolve(container) // <-- New resolve
    },
    error => {
      reject(error)
    }
  )
amranidev commented 6 years ago

Fixed!! Feel free to submit any issue or pull request!! feedbacks like this are always appreciated!!