search

gdg-x / aura

Web App for Community Management | Site
https://myaurapp.web.app/
Other
327 stars 408 forks source link

Allow customizing the 'What we do" section #3

Closed Splaktar closed 5 years ago

Splaktar commented 5 years ago

It currently has icons for Angular, Google Cloud, Firebase, Android, Tensorflow, and Assistant.

  1. It would be nice to be able to customize this list per chapter.
  2. The icons should have tooltips and alt text that is customizable.
vrijraj commented 5 years ago

New Features added

  1. Tooltips and alt text
  2. Can customize the icon from json file

and the component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

Splaktar commented 5 years ago

Looks good!

I know that this wasn't mentioned before, but it might be useful to optionally allow a url to be provided to link the icon to the docs page of the technology.

vrijraj commented 5 years ago

URL added. Need your review. https://aura-client-master.firebaseapp.com/ and component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

Splaktar commented 5 years ago

Looks good, but I would call the argument here something like url or link rather than pic: https://github.com/gdg-x/aura/blob/82f8494c19631c79d3d92eae24f421affa36a8c1/src/components/home/whatWeDo.vue#L72-L74

vrijraj commented 5 years ago

I've made the changes. Have a look at that

https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue

Splaktar commented 5 years ago

LGTM!