Closed Splaktar closed 5 years ago
New Features added
and the component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue
Looks good!
I know that this wasn't mentioned before, but it might be useful to optionally allow a url to be provided to link the icon to the docs page of the technology.
URL added. Need your review. https://aura-client-master.firebaseapp.com/ and component: https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue
Looks good, but I would call the argument here something like url
or link
rather than pic
:
https://github.com/gdg-x/aura/blob/82f8494c19631c79d3d92eae24f421affa36a8c1/src/components/home/whatWeDo.vue#L72-L74
I've made the changes. Have a look at that
https://github.com/gdg-x/aura/blob/master/src/components/home/whatWeDo.vue
LGTM!
It currently has icons for Angular, Google Cloud, Firebase, Android, Tensorflow, and Assistant.