search

gdg-x / boomerang

Easy website for your GDG Chapter
http://gdg-x.github.io/boomerang/
Apache License 2.0
74 stars 104 forks source link

Event view link in news stream is wrong #20

Closed rac2030 closed 10 years ago

rac2030 commented 10 years ago

The view link in the news stream for an event item adds the base plus url in front which then points to a 404.

Example: https://plus.google.com/https://plus.google.com/events/c9np4u6vg0k0p61athno2nqpv4c

rac2030 commented 10 years ago

Seems like a g+ API issue { "kind": "plus#activity", "etag": "\"KmFlUTDKo0bNqNhpeBygvIv8XvA/68xh6sY0V4thQWxrbz-Huzf07RY\"", "title": "We are hosting our first Google Developer Group Ski event. Together we are spending two days skiing ...", "published": "2014-01-12T19:05:23.381Z", "updated": "2014-01-20T09:34:33.000Z", "id": "z13ospghvprhwr0ki23terdxbvaizxvsg", "url": "https://plus.google.com/https://plus.google.com/events/c9np4u6vg0k0p61athno2nqpv4c", "actor": { "id": "117715978948849333403", "displayName": "GDG Zürich", "url": "https://plus.google.com/117715978948849333403", "image": { "url": "https://lh4.googleusercontent.com/-FdnP2OV-gM0/AAAAAAAAAAI/AAAAAAAAAGE/RHLZx6nUtZ8/photo.jpg?sz=50" } }

rac2030 commented 10 years ago

dirty fix in a07a7dea7b19d49537cd03fa5af83b18e45fca14

rac2030 commented 10 years ago

I merged in the dirty fix, this must be removed as soon as this issue gets fixed in API https://github.com/gdg-x/boomerang/commit/ad3a9d7ff46d00f69cf633f3ebf3668fea30da87

rac2030 commented 10 years ago

https://code.google.com/p/google-plus-platform/issues/detail?id=751

Splaktar commented 10 years ago

This issue was fixed in the Google+ API and does not appear to be occurring anymore. Removed this 'dirty fix' in pull request #24 and provided a much more complete implementation of the News page.

This issue can likely be closed when that pull request is merged.

Splaktar commented 10 years ago

Fixed as part of #24 which was merged today.