gdg-x / boomerang

Easy website for your GDG Chapter
http://gdg-x.github.io/boomerang/
Apache License 2.0
74 stars 104 forks source link

Fix for sorting of News Feed and Past Events #36

Closed neojato closed 9 years ago

neojato commented 9 years ago

The Google+ API returns posts (activities) in the order of the most recent interaction and not publication date. This change will sort the posts by publication date; new to old.

Splaktar commented 9 years ago

The Google+ API is not used for the events feed. Can you explain how the GDG-X Hub API is sorting in past events in the wrong order and how this fixes it? I am seeing them sorted new to old without this change (which seems desirable).

Please help me understand the issue with the News page. I am seeing sorting working fine without this change. Are you saying that an old post (activity) with a recent comment in it shows up before more recent posts?

friedger commented 9 years ago

For example http://gdg-brussels.org/#!/news shows the news posts in not obvious order

neojato commented 9 years ago

GitHub put both commits into the same pull request. The 1st half is about the News Feed (which uses the Google+ API). The G+ API returns posts by order of activity and not published date. The 1st change fixes the order of posts by published date.

The 2nd half is for the Event Feed. Yes, @Splaktar that uses the GDG[X] Hub API but the "Past Event" feed displays them out of order as well. This change fixes the order of past events to be chronological.

neojato commented 9 years ago

Ah, my bad @Splaktar. I missed the update to boomerang.js where there are now 2 different API calls to the Hub API to split the Future vs Past events. On GDG KC's site I'm still using the single events feed API call and then splitting them into future/past. The events API call doesn't return the events in chronological order.

Splaktar commented 9 years ago

OK, cool. I've tested this out and see what you mean. I've figured out paging of past events and will try to merge that in soon as well.