search

gdg-x / frisbee

[DEPRECATED] Android application for GDG members and organizers
https://play.google.com/store/apps/details?id=org.gdg.frisbee.android
Apache License 2.0
265 stars 169 forks source link

Remove outdate info #718

Closed ligi closed 7 years ago

ligi commented 7 years ago

This is no more needed since AS 2.3

tasomaniac commented 7 years ago

AFAIK, this optimization is only available in AS 2.3 when instant run is enabled right? Do you have more information around this?

Also if we want to remove this, we should remove the code that checks and modifies the min sdk version.

ligi commented 7 years ago

It was mentioned in the androidstudygroup slack. I removed this workaround from my apps and don't see a performance impact - but I am also using instant run. Also changed the build.gradle here now - though I do not think both changes really need to go together. And currently the markdown in the README is broken - deleting this part also fixes this ..-)

tasomaniac commented 7 years ago

Thank you for your contribution and deleting the unnecessary part from build.gradle too. 👍

tasomaniac commented 7 years ago

Merging this was not a big problem but I just want to update. According to ADB Podcast Gradleweiss it is added in build tools 2.4 and only for instant run. It is not stable currently but will be soon.

ligi commented 7 years ago

Really strange - was just searching for the conversation to check if I understood something wrong there - but I would still interpret it the same way - and this guy is on the AS team:

selection_039

Have not yet listened to this podcast - but I am a bit confused now.