search

gdg-x / hoverboard

Conference website template
https://hoverboard-master.web.app
Other
1.11k stars 1.09k forks source link

Featured videos section doesn't seem to work #1410

Closed zptoth closed 4 years ago

zptoth commented 4 years ago

Describe the bug

Featured videos section doesn't seem to work. Not even on the linked live demo site.

To Reproduce Steps to reproduce the behavior:

If you click any of the featured videos an invisible popup window is opened, that does not display anything, not even a frame, but the closing (X) sign only in the top left. The window could be closed by clicking the (X) sign.

Expected behavior The popup window should display the video referenced in default-firebase-data.json I have double-checked and the videos referenced in the demo site have the same youtube id that are referenced from the json file. eg https://www.youtube.com/watch?v=hUY8jg9-ieE Also tested by replacing sample videos with other ones. Same result.

Screenshots https://drive.google.com/file/d/1dkvYHNQyFCP7iW_ghacB00-qXnFfMdWv/view?usp=sharing

Desktop (please complete the following information):

The issue seems to be independent from browser or os.

Smartphone (please complete the following information):

The issue seems to be independent from browser or os.

abraham commented 4 years ago

I do remember that working at one point but having kind of a weird user experience. Maybe it should play in the carousel or directly open a new tab.

zptoth commented 4 years ago

This pop-up window approach could work fine. This example is not so terrible in my opinion: https://cloud.withgoogle.com/next/sf/sessions#industry-insights

abraham commented 4 years ago

Seems potentially related to https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

zptoth commented 4 years ago

Well, autoplay is not too important for me, so if the window could just pop up with the content in it that would be fine. Right now not even the content could be seen.

abraham commented 4 years ago

Digging into it a bit more I'm not sure it is auto-play. The <google-youtube-api> element doesn't seem to be working even though both dom-if values wrapping it are true.

abraham commented 4 years ago

Have a look at the preview from https://github.com/gdg-x/hoverboard/pull/1426